openlp-core team mailing list archive

[Tim Bentley <tim.bentley@xxxxxxxxx>]

Review: Needs Fixing
Still not totally convinced this is better but lest continue.

# remach   - found in the code in various places.

Inconsistent use of blank lines in the new blocks of code.

The plugins should not not need to call self.set_plugin_strings() that should be done by plugin.py in it's __init__ method.
line 257 should be move up 1 line to support above comment.
StringType is an interesting name  but it refers to a toolbar button or context menu so should it be ButtonType ?


-- 
https://code.launchpad.net/~crichter/openlp/i18n/+merge/35153
Your team OpenLP Core is subscribed to branch lp:openlp.