openlp-core team mailing list archive

[Raoul Snyman <raoul.snyman@xxxxxxxxxxxxxxxxxxxxxxxx>]

Review: Needs Fixing
Why do you have both of these files in your ignore file?

    import_lots_errors.txt
    ../import_lots_errors.txt

On line 38, setting "success" to False initially and never setting it to true means that your importer will never return a "success" to the wizard, which means that the wizard will think that your importer failed.

Please put the comment on line 79 on the next line, indented appropriately, and the comments on lines 196 and 198 on the previous lines.

On lines 154-156 you've commented some code out. If it's not needed, remove it, don't comment it out.


-- 
https://code.launchpad.net/~mjthompson/openlp/opensong_import/+merge/35330
Your team OpenLP Core is subscribed to branch lp:openlp.