openlp-core team mailing list archive

[Jonathan Corwin <j@xxxxxxxxxxxx>]

Review: Needs Fixing
Looking at the diff on the merge request page, I can see a number of lines that are wrapping (i.e. too long) so please could go through the same process and check for them.

The getString function on line 300. You're checking whether the item exists in the list and returning None if it doesn't. However I don't think you're checking for this None where the returned item is used. Therefore the program will likely crash anyway just a little later. 
I think you need to do one of the following:
1. Return something valid always, or
2. Check for None in all the places the returned item is used, or
3. Just remove the existence check in the function. (This will likely make it easier to trace the source of the problem when debugging)
-- 
https://code.launchpad.net/~crichter/openlp/i18n/+merge/36772
Your team OpenLP Core is subscribed to branch lp:openlp.