openlp-core team mailing list archive

[Tim Bentley <tim.bentley@xxxxxxxxx>]

Tim Bentley has proposed merging lp:~trb143/openlp/bugfixes1 into lp:openlp.

Requested reviews:
  OpenLP Core (openlp-core)
Related bugs:
  #637547 Editing a song in a loaded service file crashes
  https://bugs.launchpad.net/bugs/637547
  #637886 Replacing live video background with nothing live causes crash
  https://bugs.launchpad.net/bugs/637886
  #642778 enchant.DictNotFoundError: Dictionary for language 'ja_JP' could not be found
  https://bugs.launchpad.net/bugs/642778
  #651076 Preview/Live issues with saved Song/Bible/Custom items loaded into Service Manager
  https://bugs.launchpad.net/bugs/651076


Loading services have their own api into service item creation.
Was missed when sorting out issues with adding images to existing service items.
Only effects text based service items.
-- 
https://code.launchpad.net/~trb143/openlp/bugfixes1/+merge/37022
Your team OpenLP Core is requested to review the proposed merge of lp:~trb143/openlp/bugfixes1 into lp:openlp.

=== modified file 'openlp/core/lib/serviceitem.py'
--- openlp/core/lib/serviceitem.py	2010-09-16 21:19:51 +0000
+++ openlp/core/lib/serviceitem.py	2010-09-29 16:53:40 +0000
@@ -306,6 +306,7 @@
                 filename = os.path.join(path, text_image[u'title'])
                 self.add_from_command(
                     path, text_image[u'title'], text_image[u'image'] )
+        self._new_item()
 
     def merge(self, other):
         """