openlp-core team mailing list archive

[Raoul Snyman <raoul.snyman@xxxxxxxxxxxxxxxxxxxxxxxx>]

Review: Needs Fixing
278	self.text_strings = {}

That should be "self.textStrings", as per the coding standards.

350	def __init__(self, title, visible_title=None):

Please fix your docstrings underneath this function to match the function's arguments.

Otherwise it looks decent. We'll no doubt pick up some problems as we go along, but that's par for the course.
-- 
https://code.launchpad.net/~crichter/openlp/i18n/+merge/37103
Your team OpenLP Core is subscribed to branch lp:openlp.