openlp-core team mailing list archive

[Tim Bentley <667865@xxxxxxxxxxxxxxxxxx>]

The preview and the directory are created at the same time, deleted at the same time, renamed at the same time.
The code needs to look for a theme and it uses the png file as it;s starting point.  It only loads the theme to the manager if the directory containing all the info exists.

If you delete the png file then it will not load.  If you delete the
directory it will not load.

What is the problem we have safe guards here to stop incomplete themes
being loaded unless someone is playing where they should not.

Working as designed

** Changed in: openlp
       Status: New => Opinion

-- 
Theme loading does not work nicely
https://bugs.launchpad.net/bugs/667865
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.

Status in OpenLP - Worship Presentation Software: Opinion

Bug description:
Hello!

While investigating Bug #667837 I deleted the theme (preview) image(s) in ~/.local/share/openlp/themes. When I started OpenLP all my themes were gone although the xml files are still present. Then I renamed a file and started OpenLP, the result was, that the renamed theme was present but using this theme will just show a black screen with white font colour.

The problem:
We use the preview images while loading themes (without checking if the theme exists). If an image exists OpenLP assumes a theme (with the same directory name exists) and if no image exists, OpenLP assumes that there is no theme.

I do not know why that is designed as it is (maybe there is a reason I do not know about), but to me that seems not working perfectly alright (well, you could always argue that nobody will delete the preview images, but I did :-P ).

Cheers