openlp-core team mailing list archive

[Raoul Snyman <raoul.snyman@xxxxxxxxxxxxxxxxxxxxxxxx>]

Review: Needs Fixing
On lines 9, 40, you don't need None, you can just leave it out:

    order_names = self.song.verse_order.split(None)

    order_names = self.song.verse_order.split()

Also, if you could swap the encoding and the language around, I think that would be a little more user-friendly...

    CP-874 (Thai) => Thai (CP-874)
-- 
https://code.launchpad.net/~m2j/openlp/work/+merge/40796
Your team OpenLP Core is subscribed to branch lp:openlp.