← Back to team overview

openlp-core team mailing list archive

[Merge] lp:~meths/openlp/trivialfixes into lp:openlp

 

Jon Tibble has proposed merging lp:~meths/openlp/trivialfixes into lp:openlp.

Requested reviews:
  OpenLP Core (openlp-core)


Fix parsing normal biblegateway pages.

- Doesn't handle their error page (which is broken anyway).  We shouldn't be triggering this though.

- No idea how well, or not, we handle their new beta stuff yet.
-- 
https://code.launchpad.net/~meths/openlp/trivialfixes/+merge/41258
Your team OpenLP Core is requested to review the proposed merge of lp:~meths/openlp/trivialfixes into lp:openlp.
=== modified file 'openlp/plugins/bibles/lib/http.py'
--- openlp/plugins/bibles/lib/http.py	2010-10-27 17:42:10 +0000
+++ openlp/plugins/bibles/lib/http.py	2010-11-19 01:26:10 +0000
@@ -213,7 +213,7 @@
         finally:
             if not page:
                 return None
-        cleaner = [(re.compile('&nbsp;|<br />'), lambda match: '')]
+        cleaner = [(re.compile('&nbsp;|<br />|\'\+\''), lambda match: '')]
         soup = None
         try:
             soup = BeautifulSoup(page, markupMassage=cleaner)


Follow ups