openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~googol-hush/openlp/trivial into lp:openlp

To: mp+41089@xxxxxxxxxxxxxxxxxx
From: Andreas Preikschat <andreaspreikschat@xxxxxxxxxx>
Date: Sun, 21 Nov 2010 11:38:51 -0000
In-reply-to: <20101117195252.31311.6785.codereview@wampee.canonical.com>
Reply-to: mp+41089@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

> Improvement if second enabled or web bible selected  disable search combo box
> and set to verse.  This would stop the user trying to search and getting the
> error message.

hm... Performing an action on ComboBox change isn't a good idea. New user will ask themselves why the ComboBox does not offer "Text Search" anymore. (We were discussing something similar on 19th September.)
-- 
https://code.launchpad.net/~googol-hush/openlp/trivial/+merge/41089
Your team OpenLP Core is subscribed to branch lp:openlp.

References

Re: [Merge] lp:~googol-hush/openlp/trivial into lp:openlp
From: Tim Bentley, 2010-11-17