openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~trb143/openlp/bugs into lp:openlp

To: mp+42017@xxxxxxxxxxxxxxxxxx
From: Raoul Snyman <raoul.snyman@xxxxxxxxxxxxxxxxxxxxxxxx>
Date: Sat, 27 Nov 2010 20:26:12 -0000
In-reply-to: <20101127163218.14827.72632.launchpad@loganberry.canonical.com>
Reply-to: mp+42017@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing
I know this is probably old cruft, but please just try to fix things as you see them...

34	+ def generateSlideData(self, service_item, item=None, xmlVersion=False)

Um, xml_version or serviceItem? Also on lines 83, 216, 229, 242, 264, 304 and 365.

139	+ self.hide_mode = None

Shouldn't that be self.hideMode?

On line 100 yo have u'from_plugin', but on line 105 you have u'xmlVersion'. Choose one please.


-- 
https://code.launchpad.net/~trb143/openlp/bugs/+merge/42017
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~trb143/openlp/bugs into lp:openlp
From: Tim Bentley, 2010-11-27