openlp-core team mailing list archive

[Andreas Preikschat <andreaspreikschat@xxxxxxxxxx>]

> No sure about some of the removal of comments and feed back to the user in
> OSIS.
The "bibleimportform" shows the "import finished" and the users will never see the "import canceled" since the importer closes immediately after pressing "Cancel" (and the message will be overridden by "Your Bible import failed" anyway).

> Some changes seem to be for the sake of change!
I personally prefer to have things like "bible = None" at the beginning of a method.
-- 
https://code.launchpad.net/~googol-hush/openlp/bibles/+merge/42971
Your team OpenLP Core is subscribed to branch lp:openlp.