openlp-core team mailing list archive

[Raoul Snyman <raoul.snyman@xxxxxxxxxxxxxxxxxxxxxxxx>]

Review: Needs Fixing
A few things...

1. I'd prefer BibleFormat.OpenLP1, not OLP1.
2. I know it's not all your code, but if you're adding code, please make sure that you add it
   according to the standards. That means that Qt-based classes need to have camelCase members,
   including GUI widgets.

-- 
https://code.launchpad.net/~googol-hush/openlp/bibles/+merge/42971
Your team OpenLP Core is subscribed to branch lp:openlp.