openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~googol-hush/openlp/bibles into lp:openlp

To: mp+43237@xxxxxxxxxxxxxxxxxx
From: Raoul Snyman <raoul.snyman@xxxxxxxxxxxxxxxxxxxxxxxx>
Date: Thu, 09 Dec 2010 16:38:35 -0000
In-reply-to: <20101209161918.15388.60660.launchpad@loganberry.canonical.com>
Reply-to: mp+43237@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing
Andreas, just a few tweaks, and then we can merge this:

* uiBibleImportWizard => Ui_BibleImportWizard (reason: that's the name given by pyuic4)
* onOLP1FileButtonClicked => onOpenLP1FileButtonClicked (reason: button name is "openlp1FileButton")
* field(u'OLP1_location') => field(u'olp1_location') (reason: all the rest of the field names are lowercase)
-- 
https://code.launchpad.net/~googol-hush/openlp/bibles/+merge/43237
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~googol-hush/openlp/bibles into lp:openlp
From: Andreas Preikschat, 2010-12-09