openlp-core team mailing list archive

[Tim Bentley <tim.bentley@xxxxxxxxx>]

Tim Bentley has proposed merging lp:~trb143/openlp/bugs into lp:openlp.

Requested reviews:
  OpenLP Core (openlp-core)
Related bugs:
  #693150 Custom Slide Display footer option
  https://bugs.launchpad.net/bugs/693150
  #693202 delete theme
  https://bugs.launchpad.net/bugs/693202

For more details, see:
https://code.launchpad.net/~trb143/openlp/bugs/+merge/45003

Keep Raoul happy and allow the Closure dialog to be turned off.
Default is turned on though!
-- 
https://code.launchpad.net/~trb143/openlp/bugs/+merge/45003
Your team OpenLP Core is requested to review the proposed merge of lp:~trb143/openlp/bugs into lp:openlp.

=== modified file 'openlp/core/ui/advancedtab.py'
--- openlp/core/ui/advancedtab.py	2010-12-26 11:04:47 +0000
+++ openlp/core/ui/advancedtab.py	2011-01-02 16:47:53 +0000
@@ -90,6 +90,10 @@
         self.expandServiceItemCheckBox.setObjectName(
             u'expandServiceItemCheckBox')
         self.uiLayout.addWidget(self.expandServiceItemCheckBox)
+        self.enableAutoCloseCheckBox = QtGui.QCheckBox(self.uiGroupBox)
+        self.enableAutoCloseCheckBox.setObjectName(
+            u'enableAutoCloseCheckBox')
+        self.uiLayout.addWidget(self.enableAutoCloseCheckBox)
 #        self.sharedDirGroupBox = QtGui.QGroupBox(self.leftWidget)
 #        self.sharedDirGroupBox.setObjectName(u'sharedDirGroupBox')
 #        self.sharedDirGroupBox.setGeometry(QtCore.QRect(0, 65, 500, 85))
@@ -150,6 +154,8 @@
             'Double-click to send items straight to live'))
         self.expandServiceItemCheckBox.setText(translate('OpenLP.AdvancedTab',
             'Expand new service items on creation'))
+        self.enableAutoCloseCheckBox.setText(translate('OpenLP.AdvancedTab',
+            'Enable confirm on closure'))
 #        self.sharedDirGroupBox.setTitle(
 #            translate('AdvancedTab', 'Central Data Store'))
 #        self.sharedCheckBox.setText(
@@ -180,6 +186,9 @@
         self.expandServiceItemCheckBox.setChecked(
             settings.value(u'expand service item',
             QtCore.QVariant(False)).toBool())
+        self.enableAutoCloseCheckBox.setChecked(
+            settings.value(u'enable auto close',
+            QtCore.QVariant(True)).toBool())
         settings.endGroup()
 
     def save(self):
@@ -196,12 +205,14 @@
             QtCore.QVariant(self.doubleClickLiveCheckBox.isChecked()))
         settings.setValue(u'expand service item',
             QtCore.QVariant(self.expandServiceItemCheckBox.isChecked()))
+        settings.setValue(u'enable auto close',
+            QtCore.QVariant(self.enableAutoCloseCheckBox.isChecked()))
         settings.endGroup()
 
-    def onSharedCheckBoxChanged(self, checked):
-        """
-        Enables the widgets to allow a shared data location
-        """
-        self.sharedLabel.setEnabled(checked)
-        self.sharedTextEdit.setEnabled(checked)
-        self.sharedPushButton.setEnabled(checked)
\ No newline at end of file
+#    def onSharedCheckBoxChanged(self, checked):
+#        """
+#        Enables the widgets to allow a shared data location
+#        """
+#        self.sharedLabel.setEnabled(checked)
+#        self.sharedTextEdit.setEnabled(checked)
+#        self.sharedPushButton.setEnabled(checked)

=== modified file 'openlp/core/ui/mainwindow.py'
--- openlp/core/ui/mainwindow.py	2011-01-02 13:57:55 +0000
+++ openlp/core/ui/mainwindow.py	2011-01-02 16:47:53 +0000
@@ -842,7 +842,6 @@
                     QtGui.QMessageBox.Save),
                 QtGui.QMessageBox.Save)
             if ret == QtGui.QMessageBox.Save:
-                #self.ServiceManagerContents.onSaveService(True)
                 if self.ServiceManagerContents.saveFile():
                     self.cleanUp()
                     event.accept()
@@ -854,18 +853,24 @@
             else:
                 event.ignore()
         else:
-            ret = QtGui.QMessageBox.question(self,
-                translate('OpenLP.MainWindow', 'Close OpenLP'),
-                translate('OpenLP.MainWindow', 'Are you sure you want to close OpenLP?'),
-                QtGui.QMessageBox.StandardButtons(
-                    QtGui.QMessageBox.Yes |
-                    QtGui.QMessageBox.No),
-                QtGui.QMessageBox.Yes)
-            if ret == QtGui.QMessageBox.Yes:
+            if QtCore.QSettings().value(u'advanced/enable auto close',
+                QtCore.QVariant(True)).toBool():
+                ret = QtGui.QMessageBox.question(self,
+                    translate('OpenLP.MainWindow', 'Close OpenLP'),
+                    translate('OpenLP.MainWindow', 'Are you sure you want to close OpenLP?'),
+                    QtGui.QMessageBox.StandardButtons(
+                        QtGui.QMessageBox.Yes |
+                        QtGui.QMessageBox.No),
+                    QtGui.QMessageBox.Yes)
+                if ret == QtGui.QMessageBox.Yes:
+                    self.cleanUp()
+                    event.accept()
+                else:
+                    event.ignore()
+            else:
                 self.cleanUp()
                 event.accept()
-            else:
-                event.ignore()
+
 
     def cleanUp(self):
         """