openlp-core team mailing list archive

[Andreas Preikschat <andreaspreikschat@xxxxxxxxxx>]

I can easily changed this here, but there are other places where it cannot be done easily.

In plugins/songs/lib/songimport.py in finish(self) we have a list with authors, if the list is empty we add "Author unknown". Later we loop over this list and add the authors to the song.

In plugins/songs/lib/xml.py we call _process_author(self, name, song) giving the author name and the song, split the name in first_name and last_name and populate the song.

Again, we cannot solve this without making big effort or including ugly special cases.

However, we can avoid the exception, when we split the text, and take the last entry from the list, as it is done in the songimport.
-- 
https://code.launchpad.net/~googol-hush/openlp/trivial/+merge/45074
Your team OpenLP Core is requested to review the proposed merge of lp:~googol-hush/openlp/trivial into lp:openlp.