openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~m2j/openlp/work into lp:openlp

To: mp+45287@xxxxxxxxxxxxxxxxxx
From: Raoul Snyman <raoul.snyman@xxxxxxxxxxxxxxxxxxxxxxxx>
Date: Wed, 05 Jan 2011 21:00:42 -0000
In-reply-to: <20110105200323.25070.52190.launchpad@loganberry.canonical.com>
Reply-to: mp+45287@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing
670	+ if not bible:
671	+ QtGui.QMessageBox.information(self.parent.mediaItem,
672	+ translate('BiblesPlugin.BibleManager',
673	+ 'No Bibles available'),
674	+ translate('BiblesPlugin.BibleManager',
675	+ 'There are no Bibles currently installed. Please use the '
676	+ 'Import Wizard to install one or more Bibles.'))
677	+ return None

Just a small one... instead of invoking this message box yourself, rather use the new "openlp_information_message" signal, it'll anchor the message box to the main window.
-- 
https://code.launchpad.net/~m2j/openlp/work/+merge/45287
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~m2j/openlp/work into lp:openlp
From: m2j, 2011-01-05