← Back to team overview

openlp-core team mailing list archive

  1. openlp-core team
  2. Mailing list archive
  3. Message #05482

Re: [Merge] lp:~googol-hush/openlp/OpenLyrics into lp:openlp

  Thread Previous • Date Previous • • Thread Next 
Review: Approve
You might want to return "None" instead of 0 if there's no XML, and do "if song_id is None", but that's just semantics.
-- 
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/45646
Your team OpenLP Core is subscribed to branch lp:openlp.

References

  Thread Previous • Date Previous • • Thread Next