← Back to team overview

openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~googol-hush/openlp/images into lp:openlp

To: mp+46416@xxxxxxxxxxxxxxxxxx
From: Tim Bentley <tim.bentley@xxxxxxxxx>
Date: Sun, 16 Jan 2011 18:44:52 -0000
In-reply-to: <20110116183335.13349.63780.launchpad@loganberry.canonical.com>
Reply-to: mp+46416@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing
The idea is correct but I think this should be done in core not in the plugins so the send events should be inside the controllers. 
That way we have the functions managed better if new plugins ever arrive.
-- 
https://code.launchpad.net/~googol-hush/openlp/images/+merge/46416
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~googol-hush/openlp/images into lp:openlp
From: Andreas Preikschat, 2011-01-16