openlp-core team mailing list archive

[Andreas Preikschat <andreaspreikschat@xxxxxxxxxx>]

You have many whitespace (102 following, ...). The indent of line 376 is wrong. And as far as I know the indention of line 116 is wrong as well.

"(17:53:08) Meths: Yeah, but you're not breaking the line before, you're still breaking the if.  Nothing that is part of the if statement should be indented more than 4 from the if.  It means that it doesn't stick out further than the code block that follows."

(Well, we do not have any "if" here, but the idea is the same: not more than one indention level for one long line.)
-- 
https://code.launchpad.net/~crichter/openlp/shortcut-dialog/+merge/46423
Your team OpenLP Core is subscribed to branch lp:openlp.