← Back to team overview

openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~crichter/openlp/shortcut-dialog into lp:openlp

To: rimach <crichter@xxxxxx>
From: Jon Tibble <meths@xxxxxxxxxxxxxx>
Date: Mon, 17 Jan 2011 22:46:11 -0000
In-reply-to: <20110117223756.25825.24366.launchpad@loganberry.canonical.com>
Reply-to: mp+46545@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Information
Looks okay.  I'm slightly confused by the icon stuff.  If you're creating/adding icon attributes here aren't there other sections of icon creating code that should be removed or am I just not properly understanding this stuff?
-- 
https://code.launchpad.net/~crichter/openlp/shortcut-dialog/+merge/46545
Your team OpenLP Core is subscribed to branch lp:openlp.

Follow ups

Re: [Merge] lp:~crichter/openlp/shortcut-dialog into lp:openlp
From: rimach, 2011-01-18

References

[Merge] lp:~crichter/openlp/shortcut-dialog into lp:openlp
From: rimach, 2011-01-17