openlp-core team mailing list archive

[Jon Tibble <meths@xxxxxxxxxxxxxx>]

After playing around I can reproduce this with ease.

Load OpenLP and open the songmaintenanceform.
Pick a type from the three to test with (topics only have one field!)
Add an item of this type e.g. topic1
Add another item of this type e.g. topic2
Edit the _first_ item to say topic2... this will work!!

The reason it works is because the database returns the objects in id
order so it breaks the object[0].id == new_object.id check.

** Changed in: openlp
       Status: New => Confirmed

** Changed in: openlp
   Importance: Undecided => Medium

** Changed in: openlp
     Assignee: Andreas Preikschat (googol-hush) => Jon Tibble (meths)

** Changed in: openlp
    Milestone: None => 1.9.5

** Changed in: openlp
       Status: Confirmed => Fix Committed

-- 
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/703149

Title:
  Song maintenance deduplication logic needs tweaking

Status in OpenLP - Worship Presentation Software:
  Fix Committed

Bug description:
  I was struggling to get the author duplication logic to work correctly
  so that it asked me the question about merging authors.  Not sure
  exactly what's wrong as I didn't spend that long looking at it but I
  could get authors with the same first name, last name and display name
  without triggering the error message.

  I added (but haven't committed anywhere)
  log.debug("Multiple authors detected (%d)" % len(authors))
  to the checkAuthors() method to confirm that I was getting multiple results but no message.