← Back to team overview

openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~meths/openlp/trivialfixes into lp:openlp

To: Jon Tibble <meths@xxxxxxxxxxxxxx>
From: Jonathan Corwin <j@xxxxxxxxxxxx>
Date: Fri, 21 Jan 2011 18:11:21 -0000
In-reply-to: <20110121162653.31936.3985.launchpad@loganberry.canonical.com>
Reply-to: mp+47053@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

I prefer the self.import_wizard.exec_() == QtGui.QDialog.Accepted. 
It makes no assumptions as to the true/falseness of the QDialog constants and is also quite descriptive as to what .exec_() is returning and what the code is checking.

-- 
https://code.launchpad.net/~meths/openlp/trivialfixes/+merge/47053
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~meths/openlp/trivialfixes into lp:openlp
From: Jon Tibble, 2011-01-21