openlp-core team mailing list archive

[Andreas Preikschat <andreaspreikschat@xxxxxxxxxx>]

The proposal to merge lp:~googol-hush/openlp/printServiceOrder into lp:openlp has been updated.

Description changed to:

Hello!

- added the service order print
- fixed the icon of "media" items. (The plugin provides its own icon. There is no need for such a large icon.) And since self.serviceItemIconName was not used anywhere else I removed it.
- fixed a bug, which will prevent service items to be loaded (they are marked as invalid) when the contain paths like foo.bar.extension.

Note: I know that changes to mainwindow.py are not conform with the coding standards. But:
- the whole file does not conform with it -> needs to be fixed (as well as other file(s) which use variables from mainwindow.py).
- I do not have the time to fix that, so I hope you let it pass and someone who has the time for it will fixe it.

I have two sample images for you:
A detailed print: http://img40.imageshack.us/img40/8513/detailedprint.png
Simple print: http://img821.imageshack.us/img821/7666/printev.png

Cheers


For more details, see:
https://code.launchpad.net/~googol-hush/openlp/printServiceOrder/+merge/48213
-- 
https://code.launchpad.net/~googol-hush/openlp/printServiceOrder/+merge/48213
Your team OpenLP Core is requested to review the proposed merge of lp:~googol-hush/openlp/printServiceOrder into lp:openlp.