← Back to team overview

openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~googol-hush/openlp/OpenLyrics into lp:openlp

To: mp+49128@xxxxxxxxxxxxxxxxxx
From: Raoul Snyman <raoul.snyman@xxxxxxxxxxxxxxxxxxxxxxxx>
Date: Thu, 10 Feb 2011 05:02:10 -0000
In-reply-to: <20110209212726.6862.7907.codereview@wampee.canonical.com>
Reply-to: mp+49128@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve
> Select All,  DeSelect All is better that Check All, UnCheck All.

I disagree. The user is not selecting anything, they are checking the checkboxes. Those are standard buttons for checkbox interfaces.
-- 
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/49128
Your team OpenLP Core is subscribed to branch lp:openlp.

References

Re: [Merge] lp:~googol-hush/openlp/OpenLyrics into lp:openlp
From: Tim Bentley, 2011-02-09