← Back to team overview

openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~mahfiaz/openlp/opensongfixes into lp:openlp

To: mahfiaz <mahfiaz@xxxxxxxxx>
From: Jon Tibble <meths@xxxxxxxxxxxxxx>
Date: Wed, 16 Feb 2011 15:41:57 -0000
In-reply-to: <20110216151729.20944.51760.launchpad@loganberry.canonical.com>
Reply-to: mp+49985@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing
Sorry I didn't notice this earlier.  Don't remove the VerseTypes in lines 274-290.  There's nothing special about this location - the strings are centralised and used in numerous files, don't create multiple points to have to change stuff.
-- 
https://code.launchpad.net/~mahfiaz/openlp/opensongfixes/+merge/49985
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~mahfiaz/openlp/opensongfixes into lp:openlp
From: mahfiaz, 2011-02-16