← Back to team overview

openlp-core team mailing list archive

  1. openlp-core team
  2. Mailing list archive
  3. Message #06310

Re: [Merge] lp:~mahfiaz/openlp/opensongfixes into lp:openlp

  Thread Previous • Date Previous • • Thread Next 
Review: Needs Fixing
Lines 159, 162, 165, 168, 171, 174 and 177 should be VerseType.Type not a magic number.

Line 241 s/.tag/.Tags/ and then remove the .tag() method.  It is redundant.
-- 
https://code.launchpad.net/~mahfiaz/openlp/opensongfixes/+merge/50042
Your team OpenLP Core is subscribed to branch lp:openlp.

References

  Thread Previous • Date Previous • • Thread Next