openlp-core team mailing list archive

[Andreas Preikschat <700859@xxxxxxxxxxxxxxxxxx>]

I can reproduce this:
1) Import a bible
2) Cancel the import
3) Open the openlp/bibles folder
4) Now close OpenLP
Result: As OpenLP closes, a new bible is added

OR

1) Import this bible http://sourceforge.net/projects/zefania-sharp/files/Osis%20XML%20Modules%20%28raw%29/GER/Menge-Bibel/sf-menge-bibel_osis.xml/download?use_mirror=ignum
2) Wait for the import to finish (the import will fail just before finishing)
3) Open the openlp/bibles folder
4) Now close OpenLP
Result: As OpenLP closes, a new bible is added

Have a look at bibles/lib/manager. The variable self.db_cache contains
all bibles. The bug here is, that the bible is added the the db_cache
(def import_bible:184), but is not removed when the import is cancelled
or fails. When OpenLP is closed the finalise method (bibles/lib/manager)
attempts to clean up a bible which does not exists -> Creates new DB.

-- 
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/700859

Title:
  Bible importers do not clean up properly after a failed import

Status in OpenLP - Worship Presentation Software:
  Confirmed

Bug description:
  Failed bible imports leave the failed database behind leading to stack traces being reported by users who then repeat the import.
  This leads to users reporting the second stack trace instead of reporting the issue that actually cause the first import failure.

  As seen in the CVS import bug stack trace: https://bugs.launchpad.net/openlp/+bug/687309
  and the support bugs: 43, 67 and 68.