← Back to team overview

openlp-core team mailing list archive

Re: [Merge] lp:~googol-hush/openlp/trivial into lp:openlp

 

Review: Needs Fixing
I've said I'd prefer that it just be a display name and not split but even ignoring that...

This is a new place where the unknown author is being added.  Fix all the other locations to add it in the same way or, even better, refactor so that there is only one place that all the other places call.

Also this patch doesn't take care of displaying the translated unknown author in the UI.  I thought that had been discussed and agreed in all the comments above.
-- 
https://code.launchpad.net/~googol-hush/openlp/trivial/+merge/50459
Your team OpenLP Core is subscribed to branch lp:openlp.



References