openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~trb143/openlp/bugs into lp:openlp

To: mp+50528@xxxxxxxxxxxxxxxxxx
From: Jon Tibble <meths@xxxxxxxxxxxxxx>
Date: Sun, 20 Feb 2011 22:42:43 -0000
In-reply-to: <20110220203925.15333.82922.launchpad@loganberry.canonical.com>
Reply-to: mp+50528@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing
Lines 494 onwards would be better formatted like below I think as it saves using \ and we're all used to having and reading translate() calls needing their own line.

self.tagTableWidget.horizontalHeaderItem(0).setText(
    translate('OpenLP.DisplayTagTab', 'Description'))

Correct/fix docstrings, don't just remove them (line 696) - could those lines just be moved into exec_()?

No comment on not code standardising the new dialog!
-- 
https://code.launchpad.net/~trb143/openlp/bugs/+merge/50528
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~trb143/openlp/bugs into lp:openlp
From: Tim Bentley, 2011-02-20