← Back to team overview

openlp-core team mailing list archive

Re: [Merge] lp:~orangeshirt/openlp/foilpresenterimport into lp:openlp

 

to the field names:
are you referring to names like foilpresenterfolie.reihenfolge.strophennummer (line 612) they are depending on the original xml file, take a look at the example on lines 156 - 214 (ok, the first one "foilpresenterfolie" I could change if I should)

or are you referring to things like:
- "strophe" in line 550 - I could change that without problems - I choose it because it's named this way in the xml file.
- "strophennummer" in line 612 - same explanation as above

ok I see I was inconsistant in line 637 my solution was:
"for songbook in foilpresenterfolie.buch.bucheintrag" (similar in line 667 and 689)

Is a solution like line 637 / 667 / 689 ok? Or should I change "foilpresenterfolie" to "foilpresenterfoil"?
Or which way should I prefer?


to "Author unknown":
That's your decision. I will adapt the importer, if you guys have made your decision. 
The solution was a copy of the xml importer. I see It has changed - i have changed it too.

Thanks


> Line 391 etc u" should be u'
> Line 548 Spacing between the "V": 1 - No Space wanted.
> Author Unknown.  Need to resolve with Andreas.
> 
> Can we have English field names please!
-- 
https://code.launchpad.net/~orangeshirt/openlp/foilpresenterimport/+merge/50615
Your team OpenLP Core is subscribed to branch lp:openlp.



References