← Back to team overview

openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~mahfiaz/openlp/fixes_and_improvements into lp:openlp

To: mahfiaz <mahfiaz@xxxxxxxxx>
From: Tim Bentley <tim.bentley@xxxxxxxxx>
Date: Tue, 22 Feb 2011 08:31:29 -0000
In-reply-to: <20110222070331.31079.30734.launchpad@loganberry.canonical.com>
Reply-to: mp+50702@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing
If line 26 is an example then it should be a comment.
A comment around line 52 would be useful to explain what you are doing.  It is not clear and in 6 months time there will be a lot of head scratching!
-- 
https://code.launchpad.net/~mahfiaz/openlp/fixes_and_improvements/+merge/50702
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~mahfiaz/openlp/fixes_and_improvements into lp:openlp
From: mahfiaz, 2011-02-22