openlp-core team mailing list archive

[Raoul Snyman <raoul.snyman@xxxxxxxxxxxxxxxxxxxxxxxx>]

Review: Needs Fixing
Note: line numbers below relate to the diff, not the actual files.

Is there a reason line 9 uses "QtGui.QApplication" as opposed to "OpenLP", since "OpenLP is a derivative of QtGui.QApplication?

Lines 352 to 357:
- Your variables need to conform to the coding standards, i.e. they should be "do_build" not "doBuild".

Lines 363 to 368:
- Lines should be no longer than 80 characters, wrap longer lines.
- Keyword parameters should not have spaces around the = sign.

A number of other lines in build.py that need to be wrapped.

Split your build.py up into functions for each of the activities it performs.

expander.py also needs to conform to the coding standards.

Coding standards document: http://wiki.openlp.org/Development:Coding_Standards
-- 
https://code.launchpad.net/~matthiashub/openlp/osx-build-scripts/+merge/51433
Your team OpenLP Core is subscribed to branch lp:openlp.