← Back to team overview

openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~matthiashub/openlp/osx-build-scripts into lp:openlp

To: mp+51448@xxxxxxxxxxxxxxxxxx
From: Raoul Snyman <raoul.snyman@xxxxxxxxxxxxxxxxxxxxxxxx>
Date: Sun, 27 Feb 2011 19:51:55 -0000
In-reply-to: <20110227081511.29028.94472.launchpad@loganberry.canonical.com>
Reply-to: mp+51448@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing
Line 9 is also too long.

Lines 450-459 are commented out. If you're never going to use this code, rather remove it. If you are, perhaps put a condition in for it? "if a then ..."
-- 
https://code.launchpad.net/~matthiashub/openlp/osx-build-scripts/+merge/51448
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~matthiashub/openlp/osx-build-scripts into lp:openlp
From: Matthias Hub, 2011-02-27