openlp-core team mailing list archive

[Raoul Snyman <raoul.snyman@xxxxxxxxxxxxxxxxxxxxxxxx>]

Review: Needs Fixing
153 self.downloadSongs = unicode(translate('OpenLP.FirstTimeWizard',
154     'Downloading Songs.'))
155 self.downloadBible = unicode(translate('OpenLP.FirstTimeWizard',
156     'Downloading bible'))
157 self.downloadTheme = unicode(translate('OpenLP.FirstTimeWizard',
158     'Downloading theme'))

Which one is it? "Downloading Songs" or "Downloading songs"? And should it be "Downloading songs" or "Downloading songs." or "Downloading songs..."? What does the string standard say?

190 def __loadChild(self, tree, list, tag, root):
288 def __pluginStatus(self, field, tag):
293 def __updateMessage(self, text):

Why the double underscore?

681 if firstTime:
682     self.themeManagerContents.firstTime()
683 self.themeManagerContents.firstTime()

What's the point of the "if" statement, if you're gonna run the function anyway? You end up running it twice.
-- 
https://code.launchpad.net/~trb143/openlp/wizard/+merge/52324
Your team OpenLP Core is subscribed to branch lp:openlp.