← Back to team overview

openlp-core team mailing list archive

  1. openlp-core team
  2. Mailing list archive
  3. Message #06811

Re: [Merge] lp:~mahfiaz/openlp/media_fixes into lp:openlp

  Thread Previous • Date Previous • • Thread Next 
Review: Needs Fixing
Don't take away the finally block - if there is an exception the zip file handle stays open.

Don't return from an exception handler either.
-- 
https://code.launchpad.net/~mahfiaz/openlp/media_fixes/+merge/52533
Your team OpenLP Core is subscribed to branch lp:openlp.

References

  Thread Previous • Date Previous • • Thread Next