openlp-core team mailing list archive

[Armin Köhler <orangeshirt@xxxxxx>]

Review: Needs Information
> I don't understand what you are doing here, you retrieve the list of books
> from the server, then you try to get the list of books from the little book
> database, but in the case of non-English Bibles you'll get a None returned
> because that book's name is not in the book database. So basically you are
> throwing away all the book names, from what I can see.

In general I try to get the books from web and then with line 144 I try to get the book details to store all in the database in english (I thought all content of the bible database should be in english?)

In case of Bibleserver I'll become the list of books always in English. So it isn't a problem.

In case of Crosswalk I didn't realise that the booknames are not always in English I thought this is the case - that's a problem.

In case of Biblegateway the import from web is broken and I have to test a little bit more, that's why I've write the workaround which only import the books from openlp's database (line 16-24) - line 25-54 should be the solution, but first I got the problem to read the http and second I got the problem with non english book names (in this case I have seen the problem).



-- 
https://code.launchpad.net/~orangeshirt/openlp/webbibles/+merge/52615
Your team OpenLP Core is subscribed to branch lp:openlp.