openlp-core team mailing list archive

[Jon Tibble <meths@xxxxxxxxxxxxxx>]

Review: Needs Fixing
Never return from a finally - remember finally is guaranteed to run and so overrides your except return.  So take all that non-cleanup stuff out of finally too - you only want to cleanup (close the zip in this case) in finally.

Take zip.close() out of except - the finally is enough.

Put back in the zip = None before the try or you'll cause not defined errors if you do get an exception.
-- 
https://code.launchpad.net/~mahfiaz/openlp/media_fixes/+merge/52721
Your team OpenLP Core is subscribed to branch lp:openlp.