openlp-core team mailing list archive

[Tim Bentley <tim.bentley@xxxxxxxxx>]

Tim Bentley has proposed merging lp:~trb143/openlp/bugs into lp:openlp.

Requested reviews:
  OpenLP Core (openlp-core)
Related bugs:
  Bug #693150 in OpenLP: "Custom Slide Display footer option"
  https://bugs.launchpad.net/openlp/+bug/693150
  Bug #693202 in OpenLP: "delete theme"
  https://bugs.launchpad.net/openlp/+bug/693202
  Bug #712252 in OpenLP: "Service song already in database detection logic broken"
  https://bugs.launchpad.net/openlp/+bug/712252
  Bug #733271 in OpenLP: "Traceback with Song Usage Extract "
  https://bugs.launchpad.net/openlp/+bug/733271

For more details, see:
https://code.launchpad.net/~trb143/openlp/bugs/+merge/53068

Stop report generation with no path set
-- 
https://code.launchpad.net/~trb143/openlp/bugs/+merge/53068
Your team OpenLP Core is requested to review the proposed merge of lp:~trb143/openlp/bugs into lp:openlp.

=== modified file 'openlp/plugins/songusage/forms/songusagedetailform.py'
--- openlp/plugins/songusage/forms/songusagedetailform.py	2011-02-24 05:47:38 +0000
+++ openlp/plugins/songusage/forms/songusagedetailform.py	2011-03-11 19:09:06 +0000
@@ -88,6 +88,14 @@
         """
         log.debug(u'accept')
         path = unicode(self.fileLineEdit.text())
+        if path == u'':
+            Receiver.send_message(u'openlp_error_message', {
+                u'title': translate('SongUsagePlugin.SongUsageDetailForm',
+                'Report Creation'),
+                u'message': unicode(translate(
+                'SongUsagePlugin.SongUsageDetailForm', 'No output path has been'
+                ' selected for the report.'))})
+            return
         check_directory_exists(path)
         filename = unicode(translate('SongUsagePlugin.SongUsageDetailForm',
             'usage_detail_%s_%s.txt')) % (