← Back to team overview

openlp-core team mailing list archive

Re: [Merge] lp:~trb143/openlp/bugs into lp:openlp

 

Review: Needs Information
What is "200" in terms of "setTickInterval"? Can you maybe just put a comment in that explains what the unit is for that number? i.e.

    # Need the timer to trigger
    if self.serviceItem.start_time != 0:
        # Set the tick interval to 200ms
        self.mediaObject.setTickInterval(200)

Note: I see afterwards that you explain it in the docstring for the slot method, but that doesn't really have a bearing on the actual interval.
-- 
https://code.launchpad.net/~trb143/openlp/bugs/+merge/53204
Your team OpenLP Core is subscribed to branch lp:openlp.



References