← Back to team overview

openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~googol-hush/openlp/trivial into lp:openlp

To: mp+53615@xxxxxxxxxxxxxxxxxx
From: Tim Bentley <tim.bentley@xxxxxxxxx>
Date: Wed, 16 Mar 2011 12:41:20 -0000
In-reply-to: <20110316123018.26273.62047.launchpad@loganberry.canonical.com>
Reply-to: mp+53615@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing
No sure how the code change matches with the comment.
The screens object should hold the current screen so the answer should be the same.
What happens if size is not set?

Mark as needs fixing so I can have a closer look tonite.
-- 
https://code.launchpad.net/~googol-hush/openlp/trivial/+merge/53615
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~googol-hush/openlp/trivial into lp:openlp
From: Andreas Preikschat, 2011-03-16