← Back to team overview

openlp-core team mailing list archive

Re: [Merge] lp:~raoul-snyman/openlp/json into lp:openlp

 

Review: Approve
I'm going to approve as it is much better than previously. Looks great.

However one issue that may need looking at is that on my android browser, for some reason when I go into the slides or service I then need to force a reload through the browser to pick up changes. Once I've done that it works fine from that point on, until next time I come right out of the browser and back in when I need to force reload again.

Also it would be useful to have buttons on Slide controller to get direct to the Service controller, and vice versa.

Might be better perhaps if the previous/next buttons were at the top of the page, so we don't need to scroll to change verse. However blank etc are OK at the bottom though as they are.


-- 
https://code.launchpad.net/~raoul-snyman/openlp/json/+merge/53618
Your team OpenLP Core is subscribed to branch lp:openlp.



References