openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~raoul-snyman/openlp/bug-709975 into lp:openlp

To: Raoul Snyman <raoul.snyman@xxxxxxxxxxxxxxxxxxxxxxxx>
From: Jonathan Corwin <j@xxxxxxxxxxxx>
Date: Sun, 20 Mar 2011 21:46:24 -0000
In-reply-to: <20110320210229.28624.32864.launchpad@loganberry.canonical.com>
Reply-to: mp+54134@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve
Looks good.
Worked OK for different combinations of single-bible verses I tried.
Also for sane dual-bibles, it seemed to be OK too.

I did try adding a dual verse, then swapping the dual bibles around and doing a "Keep" with a second verse, and not entirely sure of the results. But then I'm not sure we should be allowing this anyway, which is outside the scope of this!
-- 
https://code.launchpad.net/~raoul-snyman/openlp/bug-709975/+merge/54134
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~raoul-snyman/openlp/bug-709975 into lp:openlp
From: Raoul Snyman, 2011-03-20