← Back to team overview

openlp-core team mailing list archive

Re: [Merge] lp:~trb143/openlp/general into lp:openlp

 

Review: Needs Fixing
342: Shouldn't this be onDoubleClick rather than onMakeLive? Otherwise I'm not sure what benefit there is in splitting the onMakeLive/makeLive functions?

Could the H/M/S variables be HourUnit/MinuteUnit/SecondUnit instead or something, they aren't overly descriptive as they are...
-- 
https://code.launchpad.net/~trb143/openlp/general/+merge/54976
Your team OpenLP Core is subscribed to branch lp:openlp.



References