openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~orangeshirt/openlp/bibles into lp:openlp

To: mp+56002@xxxxxxxxxxxxxxxxxx
From: Raoul Snyman <raoul.snyman@xxxxxxxxxxxxxxxxxxxxxxxx>
Date: Fri, 01 Apr 2011 21:51:29 -0000
In-reply-to: <20110401204339.3815.90451.launchpad@loganberry.canonical.com>
Reply-to: mp+56002@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing
Great, we're moving in the right direction. But first, some changes to your forms:

In the "Dialog" classes, change your " to ' and put a u in front of the strings that are NOT translated.

e.g. bookNameDialog.setObjectName(u'BookNameDialog')

Once you've done that, we need to figure out which place is the best place to call these two forms from. When do these forms pop up?
-- 
https://code.launchpad.net/~orangeshirt/openlp/bibles/+merge/56002
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~orangeshirt/openlp/bibles into lp:openlp
From: Armin Köhler, 2011-04-01