openlp-core team mailing list archive

[Raoul Snyman <raoul.snyman@xxxxxxxxxxxxxxxxxxxxxxxx>]

Review: Needs Fixing
def find_in_combo_box(...)

Inaccurate. It doesn't just find, it sets. Rename the function to something more like, "set_combo_box_value" or something...289

	- def onDisplayStyleComboBoxChanged(self):
	+ def ondisplayStyleComboBoxChanged(self):

Uh, no. The previous version was correct. Same goes for the other ones you changed.

Everything else looks fine.
-- 
https://code.launchpad.net/~trb143/openlp/general/+merge/57068
Your team OpenLP Core is subscribed to branch lp:openlp.