← Back to team overview

openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~trb143/openlp/general into lp:openlp

To: mp+57756@xxxxxxxxxxxxxxxxxx
From: Raoul Snyman <raoul.snyman@xxxxxxxxxxxxxxxxxxxxxxxx>
Date: Fri, 15 Apr 2011 11:22:13 -0000
In-reply-to: <20110414185827.28936.94090.launchpad@loganberry.canonical.com>
Reply-to: mp+57756@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing
28	self.mediaItemClass = mediaItemClass
29	- self.settingsTabClass = settingsTabClass
30	+ self.settings_tab_class = settings_tab_class

Which is correct? Other code is camelCase - does that need to be fixed as well?
-- 
https://code.launchpad.net/~trb143/openlp/general/+merge/57756
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~trb143/openlp/general into lp:openlp
From: Tim Bentley, 2011-04-14