← Back to team overview

openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~googol-hush/openlp/songs into lp:openlp

To: mp+57904@xxxxxxxxxxxxxxxxxx
From: Raoul Snyman <raoul.snyman@xxxxxxxxxxxxxxxxxxxxxxxx>
Date: Sat, 16 Apr 2011 07:03:24 -0000
In-reply-to: <20110415213724.6959.64520.launchpad@loganberry.canonical.com>
Reply-to: mp+57904@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing
I have a better idea. In the SongImport class create a "log_error" method, and when you encounter an error, log it. Then return True for success or False for failure, and on failure display the error log to the user.
-- 
https://code.launchpad.net/~googol-hush/openlp/songs/+merge/57904
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~googol-hush/openlp/songs into lp:openlp
From: Andreas Preikschat, 2011-04-15