← Back to team overview

openlp-core team mailing list archive

[Bug 766201] Re: Preview gets messed up if theme edit is canceled

 

Hey,

I looked at this, and the cause is, that we generate the preview image.
The preview image is not generated by the themeform/thememanager but by
the render manager. What goes wrong here, is that the theme data passed
to the render manager is saved there. So the "solution" is to make sure
that themes are reloaded in those components. However, TRB143 is
currently reworking the render manager / render and I was not able to
reproduce this bug with his beta1 branch, so I assume that this is fixed
there. (But I'll attach a patch, anyway.)

** Attachment added: "patch"
   https://bugs.launchpad.net/openlp/+bug/766201/+attachment/2072079/+files/patch

-- 
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/766201

Title:
  Preview gets messed up if theme edit is canceled

Status in OpenLP - Worship Presentation Software:
  Confirmed

Bug description:
  I double-click a song to preview it.  Then edit the "Song" theme
  (which is the default).  Decide I don't want to change the theme, so I
  click "Cancel". (The theme is still showing Default)

   I double-click another song, the preview shows a black screen.  If i
  go live I get a black screen.

  If i dbl-click the theme and then select the song again, things go
  back to normal.

  Using version OpenLP-1.9.5-bzr1477
  Theme Level set to Song Level


References