openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~j-corwin/openlp/general into lp:openlp

To: mp+58918@xxxxxxxxxxxxxxxxxx
From: Andreas Preikschat <andreaspreikschat@xxxxxxxxxx>
Date: Mon, 25 Apr 2011 06:24:29 -0000
In-reply-to: <20110424201925.4352.96692.launchpad@loganberry.canonical.com>
Reply-to: mp+58918@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing
Hello

1) Wrong indentation in line 138, 149, 196 and 199 (there is a space too much)
2) Not sure if you intended to change this, but there is no space between the item icon and the item title any more (if you intended to change this, then ignore it).
3) I think the DEFAULT_CSS should contain all available classes
4) The space between the last item and the custom notes is too small. (http://img710.imageshack.us/i/bildschirmfoto250420110.png/)
-- 
https://code.launchpad.net/~j-corwin/openlp/general/+merge/58918
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~j-corwin/openlp/general into lp:openlp
From: Jonathan Corwin, 2011-04-24