openlp-core team mailing list archive

[m2j <meinertjordan@xxxxxxxxxx>]

gushie:
Line 41 appends a single character verse order entry to the list of allowed entries. It does so in case that there is a first item of the verse type (e.g. first chorus). Otherwise the resulting verse order would be rejected in the test after diff line 60.
o123hallo:
1) all the tests are still working. I only avoid the rejection of single character entries.
2) From usability point of view it is bad to force the user to number each verse type (mainly for ending, chorus, etc.). Except of verses there is rarely a other number but 1. It is much worse to read the verse order if you append this redundancy to the entries (and it is more work to edit them). If the user wants the have this redundancy nobody will prevent this. But there is no reason to force him.
-- 
https://code.launchpad.net/~m2j/openlp/smallfix/+merge/58642
Your team OpenLP Core is subscribed to branch lp:openlp.